Removal of not needed calls to toString() in the code base #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarwell
approved these changes
Jun 29, 2021
|
Hi @obfischer can you undo the second commit please? The merge commit is not needed. |
bmarwell
requested changes
Jun 30, 2021
obfischer
force-pushed
the
improvement/466-remove-not-needed-calls-to-tostring
branch
from
892fcdb
to
4b4eb79
Compare
Fixes mojohaus#466 o Removed not needed calls to toString() to improve the code base
obfischer
force-pushed
the
improvement/466-remove-not-needed-calls-to-tostring
branch
from
4b4eb79
to
4293365
Compare
|
Rebased on master. |
bmarwell
approved these changes
Jun 30, 2021
|
Hi @bmarwell, who can merge it? I don't have the permissions according to the UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #466
o Removed not needed calls to toString() to improve the code base