Java 8 code style update and bump some maven dependencies #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: olivier lamy <olamy@apache.org>
Signed-off-by: olivier lamy <olamy@apache.org>
bmarwell
requested changes
Jun 3, 2021
There was a problem hiding this comment.
Some change requests, some nits, and can you change the PR title to something more descriptive?
I would suggest something like:
Java 8 code style updates
and then in the content box:
* Use diamond operator
* Replace for loops with enhanced for loops
* use lambdas where feasible
* …
(same for the commit message).
This way it is easier to spot the changes while browsing history.
src/main/java/org/codehaus/mojo/versions/AbstractVersionsDependencyUpdaterMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/versions/AbstractVersionsDependencyUpdaterMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/versions/AbstractVersionsDependencyUpdaterMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/versions/DisplayDependencyUpdatesMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/versions/DisplayDependencyUpdatesMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/versions/PluginUpdatesRenderer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/versions/PluginUpdatesXmlRenderer.java
Outdated
Show resolved
Hide resolved
…dencyUpdaterMojo.java Co-authored-by: Benjamin Marwell <bmarwell@apache.org>
…dencyUpdaterMojo.java Co-authored-by: Benjamin Marwell <bmarwell@apache.org>
…dencyUpdaterMojo.java Co-authored-by: Benjamin Marwell <bmarwell@apache.org>
…tesMojo.java Co-authored-by: Benjamin Marwell <bmarwell@apache.org>
|
well I just applied some intellij proposals and didn't go to all source code. there is definitely room for improvement here. |
Sorry for being so picky… don't know what bit me. =) I fixed some of my wrong suggestions in IntelliJ ;-) |
olamy
changed the title
…ed more changes Signed-off-by: olivier lamy <olamy@apache.org>
bmarwell
reviewed
Jun 4, 2021
src/main/java/org/codehaus/mojo/versions/PluginUpdatesXmlRenderer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/versions/ordering/MajorMinorIncrementalFilter.java
Show resolved
Hide resolved
Co-authored-by: Benjamin Marwell <bmarwell@apache.org>
Signed-off-by: olivier lamy <olamy@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.