Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changerecorder #416

Closed
wants to merge 1 commit into from
Closed

Changerecorder #416

wants to merge 1 commit into from

Conversation

io7m
Copy link
Contributor

@io7m io7m commented Jun 27, 2020

This provides a ChangeRecorder interface that logs changes to a machine-readable XML file whenever a pom.xml file is updated. The XML format is fully specified with an XSD schema. By default, no logging of changes occurs.

Change recording can be enabled by specifying the changeRecorderFormat and changeRecorderOutputFile properties (the latter of which logs to a versions-changes.xml file in the output directory by default). If changeRecorderFormat = none (the default), no logging occurs. If changeRecorderFormat = xml, the changes will be logged in the XML format.

Ticket: #356

@io7m
Copy link
Contributor Author

io7m commented Jun 27, 2020

Is anyone else able to see the logs of the failing checks? I get a generic "Sorry, we weren't able to download the logs" error message.

Edit: Managed to get the logs. Working on the integration test failures now.

@io7m
Copy link
Contributor Author

io7m commented Jun 27, 2020

Additionally: Do we have a set of code style settings I can load into my IDE so that I don't reformat things I didn't touch? I notice a few of the annotations have been broken across lines; I used the published Maven code style settings file in IDEA, but evidently that doesn't quite match what Mojohaus projects use.

@io7m io7m force-pushed the changerecorder branch 2 times, most recently from 1d94e04 to cb26b82 Compare June 27, 2020 10:56
@io7m
Copy link
Contributor Author

io7m commented Jul 2, 2020

This is ready for review.

@github-actions
Copy link

github-actions bot commented Jul 3, 2021

This PR is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Jul 3, 2021
@bmarwell
Copy link
Contributor

Hi @io7m
Sorry for not looking into this earlier.

Would you be willing to post an example output and rebase your PR?
Thanks!

@github-actions github-actions bot removed the Stale label Jul 13, 2021
@io7m
Copy link
Contributor Author

io7m commented Sep 20, 2021

I'll attempt to rebase this next weekend. I had completely forgotten this still existed, and didn't see the notification above.

@io7m
Copy link
Contributor Author

io7m commented Sep 20, 2021

@bmarwell There's an example output file (as a test case) as the last file in the commit:

<?xml version="1.0" encoding="UTF-8" ?>

<u:updates xmlns:u="http://www.mojohaus.org/versions-maven-plugin/schema/updates/1.0">
    <u:update u:groupId="org.mojohaus" u:artifactId="example0" u:oldVersion="0.0.1" u:newVersion="0.0.2"/>
    <u:update u:groupId="org.mojohaus" u:artifactId="example1" u:oldVersion="1.0.0" u:newVersion="2.0.0"/>
</u:updates> 

There's an XSD schema included.

This provides a ChangeRecorder interface that logs changes to a
machine-readable XML file whenever a pom.xml file is updated.

Affects: mojohaus#356
@io7m
Copy link
Contributor Author

io7m commented Oct 7, 2021

@bmarwell This has been rebased!

@io7m
Copy link
Contributor Author

io7m commented Nov 30, 2021

Apparently this PR is at risk of being closed by the stale PR workflow. I'm commenting here in the hope that the comment stops this from happening. 🙂

@io7m
Copy link
Contributor Author

io7m commented Apr 6, 2022

This isn't getting merged in any time soon, right?

@io7m
Copy link
Contributor Author

io7m commented Apr 23, 2022

Thank you! This one has been quite a long time coming. 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants