Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMPROVEMENT - allowMinorUpdates=false should imply allowMajorUpdates=false #283

Closed
solter opened this issue May 30, 2018 · 3 comments · Fixed by #745
Closed

IMPROVEMENT - allowMinorUpdates=false should imply allowMajorUpdates=false #283

solter opened this issue May 30, 2018 · 3 comments · Fixed by #745

Comments

@solter
Copy link

solter commented May 30, 2018

I have attached a zip file mvnVersionsIssues.zip sufficient for creating a minimal working example of this bug.
It contains two mvn projects, dots1 and dots2, where dots2 depends on dots1.

Here is a complete list of dots1 versions that I have created via modifying the version declaration in the pom and running mvn install without any other changes:

  • 3.0.0-0
  • 2.1.1-1
  • 2.1.0-1
  • 2.1.0-0
  • 2.0.1-1
  • 2.0.1-0
  • 2.0.0-11

when dots2 depends on dots1 version 2.0.0-11, and I run the command
$ mvn -DallowMinorUpdates=false versions:use-latest-versions
the dots1 dependency updates to version 3.0.0-0
Whereias if I run
$ mvn -DallowMajorUpdates=false -DallowMinorUpdates=false versions:use-latest-versions
then the dots1 dependency correctly updates to version 2.0.1-1

Ideally both commands yield the same update to version 2.0.1-1

@jdileonardo
Copy link
Contributor

i think this might be solved with this

#274

@nsidhaye
Copy link

nsidhaye commented Sep 5, 2018

Linking #243

@jarmoniuk
Copy link
Contributor

I think it's a bug and not an enhancement. These allow...updates flags are not orthogonal, but indeed imply themselves. And while it's theoretically possible to e.g. only allow major updates, but not minor updates, it would be highly unintuitive to e.g. only allow updates from 1.1.x to 2.1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants