Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 11 build breaks because of cobertura-maven-plugin #77

Closed
andham opened this issue Jan 19, 2020 · 4 comments
Closed

Java 11 build breaks because of cobertura-maven-plugin #77

andham opened this issue Jan 19, 2020 · 4 comments
Assignees
Labels

Comments

@andham
Copy link
Member

andham commented Jan 19, 2020

The project is not buildable with Java 11. It fails due to the cobertura-m-p, which can be seen in the Travis builds.
Also see #39 and #59 which are about issues with cobertura.
The issue about java 11 filed for cobertura-m-p: mojohaus/cobertura-maven-plugin#43

@andham andham added the bug label Jan 19, 2020
@andham andham added this to the 51 milestone Jan 19, 2020
@andham
Copy link
Member Author

andham commented Jan 19, 2020

As cobertura-m-p isn't Java 11 compatible, what should we do? Should we fix it, or should we switch to some other code coverage tool? If we should switch, to what?
Or, should we just remove the code coverage report all together? I think our mojos mainly have tests via the invoker-m-p so that coverage will not be included in the report anyways as those tests are not instrumented.

@hboutemy
Copy link
Member

+1 to remove

@andham andham self-assigned this Jan 20, 2020
@andham
Copy link
Member Author

andham commented Jan 21, 2020

It looks like Cobertura isn't Java 11 compatible, see cobertura/cobertura#381. So fixing cobertura-m-p to be Java 11 compatible isn't possible.

@andham
Copy link
Member Author

andham commented Jan 21, 2020

Discussion on dev mailing list: https://groups.google.com/forum/#!topic/mojohaus-dev/8cspr6c9o7k

Conclusion: I nice thing to have, but need to switch to e.g. JaCoCo. Most likely we need to instrument the invoker-m-p driven tests as well as most mojo test are there.

But for now we settle on removing coberture-m-p. Something else could be added in the future if needed.

andham added a commit to andham/mojo-parent that referenced this issue Jan 21, 2020
@andham andham closed this as completed in bca18a7 Jan 21, 2020
@mfriedenhagen mfriedenhagen changed the title Fix Java 11 build Java 11 build breaks because of cobertura-maven-plugin Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants