Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#225] add SHA-512 hashes #226

Merged
merged 1 commit into from Feb 16, 2022
Merged

[#225] add SHA-512 hashes #226

merged 1 commit into from Feb 16, 2022

Conversation

bmarwell
Copy link
Contributor

fixes #225

@bmarwell bmarwell mentioned this pull request Jan 27, 2022
Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as it doesn't hurt central it's fine

@bmarwell
Copy link
Contributor Author

as long as it doesn't hurt central it's fine

On the contrary. Looking over at ASF, they require those.

Reading this, we even might want to add SHA-256.

@bmarwell bmarwell merged commit 49ef8dc into master Feb 16, 2022
@bmarwell bmarwell deleted the #225_sha512 branch February 16, 2022 07:44
@olamy
Copy link
Member

olamy commented Feb 17, 2022

as long as it doesn't hurt central it's fine

On the contrary. Looking over at ASF, they require those.

well it's a bit different. Maven Central and Apache have different expectations.
do not confuse maven central and Apache distribution :)
this PR just change what will be uploaded to Maven Central (i.e https://repo1.maven.org/maven2/) this is not an official Apache distribution place.
What is related to https://infra.apache.org/release-distribution.html#sigs-and-sums is the official Apache distribution area which have a mirroring system all over the world and some archive here https://archive.apache.org/.
mojohaus is not part of Apache and do not have to follow the same rules.
what we define here is the publication to Maven central (https://central.sonatype.org/publish/#individual-projects-open-source-software-repository-hosting-ossrh)

Reading this, we even might want to add SHA-256.

@bmarwell
Copy link
Contributor Author

Yes I know. I still think it's a good rule to follow. That's all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add sha512 hashes
2 participants