Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overrideFile is deprecated #416

Open
bogdanb opened this issue Dec 1, 2021 · 2 comments
Open

overrideFile is deprecated #416

bogdanb opened this issue Dec 1, 2021 · 2 comments

Comments

@bogdanb
Copy link

bogdanb commented Dec 1, 2021

I’m not sure I understand everything correctly, but it seems to me that overrideFile should not have been deprecated, because the newer overrideUrl property cannot be used to reproduce the previous behavior.

overrideUrl only allows URLs, which are absolute, thus AFAIK cannot be used to point to a file inside the repository. (I guess on Linux it might be possible, using stuff like ${project.source.directory} to assemble a file: URL, but on Windows that will return some C:\path\with\drive\letter, which can’t do the same thing.

Using overrideFile, you can just put the override file anywhere inside the repository. With overrideUrl, you need to pick one of:

  • put the file on a web server, which requires a server and means no build is possible without a network connection
  • use some hard-coded file: URL, which means you can’t just get the repo and build, you need to place the in a particular path
  • use the default path, which is inconvenient
@slawekjaranowski
Copy link
Member

similar to ##411

@maxl2287
Copy link

Any solution on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants