Fix #331 overrideUrl doesn't work #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppalaga
requested changes
May 10, 2019
src/test/java/org/codehaus/mojo/license/LicenseMojoUtilsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/codehaus/mojo/license/LicenseMojoUtilsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/codehaus/mojo/license/LicenseMojoUtilsTest.java
Outdated
Show resolved
Hide resolved
|
Just to make sure: When you ask me to "squash the commit", I do that locally and then force-push, right? |
Yes. |
digulla
force-pushed
the
bugfix/331-overrideUrl_doesnt_work
branch
from
dd21738
to
cd63928
Compare
|
I'm wondering why this issue is still in the state "Changes requested". Did I miss something? |
ppalaga
changed the title
|
Thanks @digulla ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to just checking the result, I've also added logging so users of the plugin can find out what it's loading and from where and why without having to start a debugger.
Code coverage is at 83.9%
Sore point is the DEFAULT_OVERRIDE_THIRD_PARTY which is used in the default path of the code; I could wrap the constant in a getter to switch between "exists" and "missing" cases.