Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The plugin performs artifact resolution first and then includedScopes. #219

Open
Tibor17 opened this issue Jan 29, 2019 · 6 comments
Open
Milestone

Comments

@Tibor17
Copy link
Contributor

Tibor17 commented Jan 29, 2019

We have includedScopes=compile, runtime.
Nevertheless the plugin resolves test dependencies and should not.

@ppalaga
Copy link
Contributor

ppalaga commented Feb 1, 2019

Please add steps to reproduce, ideally in from of an integration test under https://github.com/mojohaus/license-maven-plugin/tree/master/src/it

Which mojo(s) does this relate to?

@ppalaga ppalaga added this to the Backlog milestone Feb 1, 2019
@ppalaga
Copy link
Contributor

ppalaga commented Feb 13, 2019

@Tibor17 do you want to add the missing details? Otherwise, I'd close this as non-reproducible.

@Tibor17
Copy link
Contributor Author

Tibor17 commented Feb 13, 2019

It's in our commercial project.
This is performance issue. Behavior is ok.
It may to do with an algorithm of the Maven Core 2.2.1.
While plugin resolves dependencies, all are being downloaded and includedScopes is done afterwards which is bad because this takes too long and some dependencies fail to download.

@ppalaga
Copy link
Contributor

ppalaga commented Feb 13, 2019

It may to do with an algorithm of the Maven Core 2.2.1.

The maven-core dependency has <scope>provided</scope> https://github.com/mojohaus/license-maven-plugin/blob/master/pom.xml#L172-L176 so you should get the version delivered by your current maven runtime. In other words upgrading the dep version in our pom would not help per se.

Or you mean that newer maven-core offers an API to "filter before" download?

@Tibor17
Copy link
Contributor Author

Tibor17 commented Feb 13, 2019

@ppalaga
I mean newer version - mavenVersion.
I tried to upgrade the project to 3.0 but it's not only about mavenVersion.
I can do it later, not today.

@ppalaga
Copy link
Contributor

ppalaga commented Jun 22, 2019

@Tibor17, could you please check if the current issue was solved by #325 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants