Fix #288 Add configuration option to omit dependency exclusions stanzas from flattened POM #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slachiewicz - are you the best person to ask to review this PR (and the proposal behind it #288)? |
|
@olamy - would you mind reviewing this PR or pointing me to someone who could? Thanks! |
josple
changed the title
slawekjaranowski
requested changes
Jul 30, 2022
src/test/java/org/codehaus/mojo/flatten/FlattenMojoOmitExclusionsTest.java
Outdated
Show resolved
Hide resolved
slawekjaranowski
approved these changes
Aug 4, 2022
|
please squash to final one commit |
Introduces a new 'omitExclusions' configuration option that is false by default to maintain backwards compatible behaviour. When this new configuration option is explicitly set to true then this will result in the flattened POM omitting all exclusions stanzas from the dependency stanzas. Fixes mojohaus#288
|
Thanks for approving @slawekjaranowski . The commits have now been squashed. Is there anything I need to do from a version change perspective? Should I update the version to 1.3.0-SNAPSHOT - or is this controlled by your build system or some other process? |
|
Thank you for your help with merging this @slawekjaranowski. Not sure on the convention for creating a new release but I have raised a request via #292 in the first instance. |
slawekjaranowski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #288