From f85967aa8f965579f6796661de555f3a777cfc4e Mon Sep 17 00:00:00 2001 From: Clay Jensen-Reimann Date: Tue, 31 May 2022 10:11:33 -0500 Subject: [PATCH] Set `project.originalModel` after flattening Based on the discussion in maven-shade-plugin#129 https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843695691 It seems that the flatten plugin should update the `originalModel` property after we flatten the pom. --- .../flatten-shaded-drp/invoker.properties | 1 + src/it/projects/flatten-shaded-drp/pom.xml | 105 ++++++++++++++++++ .../src/main/java/com/example/Main.java | 12 ++ .../projects/flatten-shaded-drp/verify.groovy | 41 +++++++ .../codehaus/mojo/flatten/FlattenMojo.java | 1 + 5 files changed, 160 insertions(+) create mode 100644 src/it/projects/flatten-shaded-drp/invoker.properties create mode 100644 src/it/projects/flatten-shaded-drp/pom.xml create mode 100644 src/it/projects/flatten-shaded-drp/src/main/java/com/example/Main.java create mode 100644 src/it/projects/flatten-shaded-drp/verify.groovy diff --git a/src/it/projects/flatten-shaded-drp/invoker.properties b/src/it/projects/flatten-shaded-drp/invoker.properties new file mode 100644 index 00000000..f6e40a28 --- /dev/null +++ b/src/it/projects/flatten-shaded-drp/invoker.properties @@ -0,0 +1 @@ +invoker.goals=package \ No newline at end of file diff --git a/src/it/projects/flatten-shaded-drp/pom.xml b/src/it/projects/flatten-shaded-drp/pom.xml new file mode 100644 index 00000000..1d780b4b --- /dev/null +++ b/src/it/projects/flatten-shaded-drp/pom.xml @@ -0,0 +1,105 @@ + + 4.0.0 + org.codehaus.mojo.flatten.its + flatten-shaded-drp + 0.0.1${rev}-SNAPSHOT + + + 3.2.1 + + 1.8 + 1.8 + + + + + com.google.guava + guava + 16.0.1 + + + org.apache.maven + maven-archiver + 2.5 + + + + + package + + + + org.codehaus.mojo + flatten-maven-plugin + + true + ossrh + true + + + + flatten + prepare-package + + flatten + + + + + + + org.apache.maven.plugins + maven-shade-plugin + 3.3.0 + + true + true + + + com.google.guava:* + + + + + + shade + package + + shade + + + + + + + + + + + foo + + + willNotBeActive + + + + + + org.codehaus.mojo.flatten.its + core + ${flatten.its.version} + + + + + + + + no-one + @repository.proxy.url@ + + + + + diff --git a/src/it/projects/flatten-shaded-drp/src/main/java/com/example/Main.java b/src/it/projects/flatten-shaded-drp/src/main/java/com/example/Main.java new file mode 100644 index 00000000..c9cba180 --- /dev/null +++ b/src/it/projects/flatten-shaded-drp/src/main/java/com/example/Main.java @@ -0,0 +1,12 @@ +package com.example; + +import java.util.List; +import com.google.common.collect.ImmutableList; +import org.apache.maven.archiver.MavenArchiver; + +public class Main { + public static void main(String[] args) { + List l = ImmutableList.of(); + MavenArchiver a = new MavenArchiver(); + } +} \ No newline at end of file diff --git a/src/it/projects/flatten-shaded-drp/verify.groovy b/src/it/projects/flatten-shaded-drp/verify.groovy new file mode 100644 index 00000000..a6a3813e --- /dev/null +++ b/src/it/projects/flatten-shaded-drp/verify.groovy @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +File originalPom = new File( basedir, 'pom.xml' ) +assert originalPom.exists() + +def originalProject = new XmlSlurper().parse( originalPom ) +assert 1 == originalProject.dependencies.size() +assert 2 == originalProject.dependencies.dependency.size() + +File flattendPom = new File( basedir, 'dependency-reduced-pom.xml' ) +assert flattendPom.exists() + +def flattendProject = new XmlSlurper().parse( flattendPom ) +assert 1 == flattendProject.dependencies.size() +assert 1 == flattendProject.dependencies.dependency.size() + +def archiver = flattendProject.dependencies.dependency.find { + it.groupId == 'org.apache.maven' && it.artifactId == 'maven-archiver' +} +assert '2.5' == archiver.version.text() +assert 'compile' == archiver.scope.text() + +assert 0 == flattendProject.build.size() +assert 0 == flattendProject.profiles.size() +assert 0 == flattendProject.pluginRepositories.size() \ No newline at end of file diff --git a/src/main/java/org/codehaus/mojo/flatten/FlattenMojo.java b/src/main/java/org/codehaus/mojo/flatten/FlattenMojo.java index 918c53d5..a4bb4625 100644 --- a/src/main/java/org/codehaus/mojo/flatten/FlattenMojo.java +++ b/src/main/java/org/codehaus/mojo/flatten/FlattenMojo.java @@ -422,6 +422,7 @@ public void execute() if ( isUpdatePomFile() ) { this.project.setPomFile( flattenedPomFile ); + this.project.setOriginalModel( flattenedPom ); } }