New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AbstractRequireRoles.getRolesFromString #133

Merged

slachiewicz merged 1 commit into mojohaus:master from pzygielo:csv

Jul 31, 2021

Contributor

pzygielo commented Jul 31, 2021 •

edited

Add UT for the new method
Extract method
Rename parameters and local variable

pzygielo force-pushed the csv branch 2 times, most recently from a99f5fb to be3145f Compare

July 31, 2021 15:29


          Refactor AbstractRequireRoles.getRolesFromString

b0b613d

- Add UT for the new method
- Extract method
- Rename parameters and local variable

pzygielo force-pushed the csv branch from be3145f to b0b613d Compare

July 31, 2021 15:31

pzygielo marked this pull request as ready for review

July 31, 2021 15:35

slachiewicz approved these changes

View reviewed changes

slachiewicz merged commit c97a9d2 into mojohaus:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment