Do not drop environment variables that contain '=' in their value, or have no value. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this ever going to be fixed in a release? |
|
Any chance someone with the power could trigger this build again. I think the build failure was down to the build system at the time, not the code changes. |
|
Could you rebase it to current master? It uses old JDK versions, build passed on Oracle JDK8, but failed on JDK7. I see newer builds use OpenJDK. |
|
@dmatej PR branch rebased and everything seems to be working and tests passing. 😃 |
pzygielo
reviewed
Sep 10, 2020
|
Bump! Could this be merged please. |
|
@dmatej Thanks! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed whilst doing a little home project that this plugin will not pass environment variables to the java application from a script file if the environment variable in the script file has an '=' character in it. It silently ignores them.
This change will read environment variables that contain '=' characters and add them to the Java application's environment.
It will also include environment variables whose value is empty.
Finally, it will log a warning for any environment variables that are dropped, though I don't think it would ever happen because the 'env' command will always return
VAR=VAL
or
VAR=