Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use primitive to allow it to be resolved by @value in javadoc #99

Merged
merged 1 commit into from Jul 14, 2020
Merged

Use primitive to allow it to be resolved by @value in javadoc #99

merged 1 commit into from Jul 14, 2020

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo commented Jul 8, 2020 •
edited

Currently following is reported:

[ERROR] Exit code: 1 - .../src/main/java/org/codehaus/mojo/buildhelper/ReserveListenerPortMojo.java100 error: value does not refer to a constant
[ERROR]      * If {@link #maxPortNumber} is specified, defaults to {@value #FIRST_NON_ROOT_PORT_NUMBER}.
[ERROR]                                                            ^

With this fix applied, javadoc looks like:
javadoc-resolved

Separate case is for site documentation, where it's still presented as
site-unresolved
and one has to search to confirm its value.

@pzygielo
Use primitive to allow it to be resolved by @value in javadoc
326c708 
Currently following is reported:
```
[ERROR] Exit code: 1 - .../src/main/java/org/codehaus/mojo/buildhelper/ReserveListenerPortMojo.java:100: error: value does not refer to a constant
[ERROR]      * If {@link #maxPortNumber} is specified, defaults to {@value #FIRST_NON_ROOT_PORT_NUMBER}.
[ERROR]                                                            ^
```
@pzygielo pzygielo marked this pull request as ready for review July 14, 2020 16:55
@pzygielo
Copy link
Contributor Author

pzygielo commented Jul 14, 2020 •
edited

May I ask for review, please?

stefanseifert
stefanseifert approved these changes Jul 14, 2020
View reviewed changes
Copy link
Collaborator

@stefanseifert stefanseifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@stefanseifert stefanseifert added this to the 3.3.0 milestone Jul 14, 2020
@stefanseifert stefanseifert merged commit 674b2a8 into mojohaus:master Jul 14, 2020
@pzygielo pzygielo deleted the primitive branch July 14, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanseifert stefanseifert stefanseifert approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pzygielo @stefanseifert