Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use maven-plugin-plugin in version managed in parent #97

Merged
merged 1 commit into from Jul 14, 2020
Merged

Use maven-plugin-plugin in version managed in parent #97

merged 1 commit into from Jul 14, 2020

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo commented Jul 8, 2020 •
edited

Currently used version generates invalid javadoc for
target/generated-sources/plugin/org/codehaus/mojo/buildhelper/HelpMojo.java:

   346	    /**
   347	     * Splits the specified text into lines of convenient display length.
   348	     *
   349	     * @param text       The text to split into lines, must not be <code>null</code>.
   350	     * @param indent     The base indentation level of each line, must not be negative.
   351	     * @param indentSize The size of each indentation, must not be negative.
   352	     * @param lineLength The length of the line, must not be negative.
   353	     * @return The sequence of display lines, never <code>null</code>.
   354	     * @throws NegativeArraySizeException if <code>indent < 0</code>
   355	     */
   356	    private static List<String> toLines( String text, int indent, int indentSize, int lineLength )

where line 354 contains < instead of entity.

3.5.1 m-p-p has it fixed (MPLUGIN-324) and comes from current parent.

@pzygielo
Copy link
Contributor Author

pzygielo commented Jul 8, 2020

May I ask for review, please?

@stefanseifert stefanseifert self-requested a review July 14, 2020 13:20
@stefanseifert
Copy link
Collaborator

makes sense!
in the next version of the mojo-parent version 3.6.0 of maven-plugin-plugin is defined by default:
https://github.com/mojohaus/mojo-parent/blob/95a819cc9b17dd9028b312b0c0a59967c788935c/pom.xml#L357

a release of this mojo-parent is planned soon, i think it would be best to update to this next version once released and remove the plugin version in the pom of this plugin.

stefanseifert
stefanseifert requested changes Jul 14, 2020
View reviewed changes
Copy link
Collaborator

@stefanseifert stefanseifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as alternative we could just remove the plugin version immediately, because the mojo-parent 50 that is currently references already contains maven-plugin-plugin 3.5.1 - we forgot to remove the local plugin version when updating to parent 50.

@pzygielo pzygielo marked this pull request as draft July 14, 2020 13:30
@pzygielo pzygielo changed the title Bump maven-plugin-plugin Use maven-plugin-plugin in version managed in parent Jul 14, 2020
@pzygielo pzygielo marked this pull request as ready for review July 14, 2020 13:43
@pzygielo
Use maven-plugin-plugin in version managed in parent
cdcf31a 
Currently used version generates invalid javadoc for
`target/generated-sources/plugin/org/codehaus/mojo/buildhelper/HelpMojo.java`:

```java
   346	    /**
   347	     * Splits the specified text into lines of convenient display length.
   348	     *
   349	     * @param text       The text to split into lines, must not be <code>null</code>.
   350	     * @param indent     The base indentation level of each line, must not be negative.
   351	     * @param indentSize The size of each indentation, must not be negative.
   352	     * @param lineLength The length of the line, must not be negative.
   353	     * @return The sequence of display lines, never <code>null</code>.
   354	     * @throws NegativeArraySizeException if <code>indent < 0</code>
   355	     */
   356	    private static List<String> toLines( String text, int indent, int indentSize, int lineLength )
```
where line 354 contains `<` instead of entity.

3.5.1 m-p-p has it fixed (MPLUGIN-324) and comes from current parent.
@pzygielo pzygielo marked this pull request as draft July 14, 2020 13:45
@pzygielo
Copy link
Contributor Author

Hmm... it seems I didn't push corrected version.

@pzygielo pzygielo marked this pull request as ready for review July 14, 2020 13:54
stefanseifert
stefanseifert approved these changes Jul 14, 2020
View reviewed changes
Copy link
Collaborator

@stefanseifert stefanseifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stefanseifert stefanseifert added this to the 3.3.0 milestone Jul 14, 2020
@stefanseifert stefanseifert merged commit 9e355c3 into mojohaus:master Jul 14, 2020
@pzygielo pzygielo deleted the bump-m-p-p branch July 14, 2020 14:13
@stefanseifert stefanseifert added the dependencies Pull requests that update a dependency file label Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanseifert stefanseifert stefanseifert approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pzygielo @stefanseifert