Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site: Properly showing 'value' tag on regex-properties usage page #76

Merged
merged 1 commit into from Jun 2, 2020

Conversation

gmatheu
Copy link
Contributor

@gmatheu gmatheu commented Apr 24, 2019

Escaping '${project.version}' on usage.apt.vm template.

On Set a property by applying a regex replacement to a value of the Usage page section.

Before, it showed the current version of the plugin since the value was actually being replaced (wich is confusing because the example is removing -SNAPSHOT from that value): <value>3.0.0</value>

Now it shows the literal value: <value>${project.version}</value>

@stefanseifert stefanseifert added this to the 3.2.0 milestone Jun 2, 2020
@stefanseifert stefanseifert self-assigned this Jun 2, 2020
@stefanseifert stefanseifert merged commit f9585af into mojohaus:master Jun 2, 2020
@stefanseifert
Copy link
Collaborator

lgtm, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants