Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc error on the comparison page - Dask does support a quantile method (albeit approximate) #3354

Closed
ianozsvald opened this issue Aug 19, 2021 · 1 comment · Fixed by #3468
Labels
bug 🦗 Something isn't working

Comments

@ianozsvald
Copy link

On https://modin.readthedocs.io/en/latest/comparisons/dask.html you note Dask is currently missing multiple APIs from pandas that Modin has implemented. Of note: Dask does not implement iloc, MultiIndex, apply(axis=0), quantile, median, and more.

Dask has a quantile method for both Series and DataFrame: https://docs.dask.org/en/latest/generated/dask.dataframe.DataFrame.quantile.html . I'd suggest either removing "quantile" from that sentence or maybe noting that only an approximate quantile is available.

I agree that an exact median is not supported, nor is that likely.

The approximate quantile method has been improved (details for the morbid: dask/dask#3819 (comment) ), the current default has better error characteristics than from several years back and a newer tdigest options allows for error guarantees.

@ianozsvald ianozsvald added the bug 🦗 Something isn't working label Aug 19, 2021
@YarShev
Copy link
Collaborator

YarShev commented Aug 20, 2021

Hi @ianozsvald , thanks for the notice! We'll definitely correct this.

anmyachev added a commit to anmyachev/modin that referenced this issue Sep 23, 2021
Signed-off-by: Myachev <anatoly.myachev@intel.com>
YarShev pushed a commit that referenced this issue Sep 28, 2021
Signed-off-by: Myachev <anatoly.myachev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🦗 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants