-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unskip tests with Future version pandas #3142
Comments
@Rubtsowa , what pandas version do you have installed? |
@YarShev 1.2.4 |
Having discussed offline it was found out the issue is related to BaseOnPython tests only. To get dtype of the underlying object to_pandas method is called underneath that creates an empty pandas DataFrame. That empty DataFrame has object as dtype that is retured to user side. |
so what is the plan here then? |
We need to wait Pandas 2.0 for test unskipping |
Hi @Rubtsowa @Garra1980 @dchigarev @YarShev has this issue been resolved? |
…n-project#3142 Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Fixed in #5995. |
Currently we have problem with tests: test___repr__ - https://github.com/modin-project/modin/blob/master/modin/pandas/test/test_series.py#L501 , test_dtype_empty - https://github.com/modin-project/modin/blob/master/modin/pandas/test/test_series.py#L1539 .
I found this problem when I was working on #2164.
These tests creating empty Series. Modin have default type for Series
object
. But currently Pandas have default type for Seriesfloat64
. Therefore now tests failed.Currently version pandas have next DeprecationWarning:
DeprecationWarning: The default dtype for empty Series will be 'object' instead of 'float64' in a future version. Specify a dtype explicitly to silence this warning.
More details about this you can see here: https://pandas.pydata.org/pandas-docs/stable/whatsnew/v1.0.0.html
Therefore tests will be passed after new version Pandas.
The text was updated successfully, but these errors were encountered: