Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip tests with Future version pandas #3142

Closed
Rubtsowa opened this issue Jun 9, 2021 · 9 comments
Closed

Unskip tests with Future version pandas #3142

Rubtsowa opened this issue Jun 9, 2021 · 9 comments
Labels
bug 🦗 Something isn't working Needs more information ❔ Issues that require more information from the reporter P3 Very minor bugs, or features we can hopefully add some day. Testing 📈 Issues related to testing

Comments

@Rubtsowa
Copy link
Contributor

Rubtsowa commented Jun 9, 2021

Currently we have problem with tests: test___repr__ - https://github.com/modin-project/modin/blob/master/modin/pandas/test/test_series.py#L501 , test_dtype_empty - https://github.com/modin-project/modin/blob/master/modin/pandas/test/test_series.py#L1539 .

I found this problem when I was working on #2164.

These tests creating empty Series. Modin have default type for Series object. But currently Pandas have default type for Series float64. Therefore now tests failed.

Currently version pandas have next DeprecationWarning:
DeprecationWarning: The default dtype for empty Series will be 'object' instead of 'float64' in a future version. Specify a dtype explicitly to silence this warning.

More details about this you can see here: https://pandas.pydata.org/pandas-docs/stable/whatsnew/v1.0.0.html

Therefore tests will be passed after new version Pandas.

@YarShev
Copy link
Collaborator

YarShev commented Jun 17, 2021

@Rubtsowa , I am not sure that I understand the issue. Example:

import pandas
import modin.pandas as pd
ps = pandas.Series()
Series([], dtype: float64)
ms = pd.Series()
Series([], dtype: float64)
ps.dtypes == ms.dtypes
True

Can you elaborate?

Related to #3141 .

@YarShev
Copy link
Collaborator

YarShev commented Jun 17, 2021

@Rubtsowa , what pandas version do you have installed?

@Rubtsowa
Copy link
Contributor Author

@YarShev 1.2.4

@Rubtsowa
Copy link
Contributor Author

Rubtsowa commented Jun 17, 2021

Having discussed offline it was found out the issue is related to BaseOnPython tests only. To get dtype of the underlying object to_pandas method is called underneath that creates an empty pandas DataFrame. That empty DataFrame has object as dtype that is retured to user side.

@YarShev
Copy link
Collaborator

YarShev commented Jun 17, 2021

42078

@Garra1980
Copy link
Collaborator

so what is the plan here then?

@Garra1980
Copy link
Collaborator

We need to wait Pandas 2.0 for test unskipping

@RehanSD
Copy link
Collaborator

RehanSD commented Oct 12, 2022

Hi @Rubtsowa @Garra1980 @dchigarev @YarShev has this issue been resolved?

@RehanSD RehanSD added Needs more information ❔ Issues that require more information from the reporter P3 Very minor bugs, or features we can hopefully add some day. labels Oct 12, 2022
@mvashishtha mvashishtha added the Testing 📈 Issues related to testing label Oct 12, 2022
anmyachev added a commit to anmyachev/modin that referenced this issue Apr 15, 2023
…n-project#3142

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
Copy link
Collaborator

Fixed in #5995.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🦗 Something isn't working Needs more information ❔ Issues that require more information from the reporter P3 Very minor bugs, or features we can hopefully add some day. Testing 📈 Issues related to testing
Projects
None yet
Development

No branches or pull requests

6 participants