From 78d610d1d0d50041945712ec511b68c96d8ba9de Mon Sep 17 00:00:00 2001 From: web-padawan Date: Sun, 5 Jun 2022 22:48:04 +0300 Subject: [PATCH] chore: fix compilation errors --- .changeset/chatty-ghosts-argue.md | 6 ++++++ .../src/createRollupPluginContextAdapter.ts | 1 + packages/dev-server-rollup/src/rollupAdapter.ts | 2 +- 3 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 .changeset/chatty-ghosts-argue.md diff --git a/.changeset/chatty-ghosts-argue.md b/.changeset/chatty-ghosts-argue.md new file mode 100644 index 000000000..6a6e15ecd --- /dev/null +++ b/.changeset/chatty-ghosts-argue.md @@ -0,0 +1,6 @@ +--- +'@web/dev-server-rollup': patch +'@web/dev-server': patch +--- + +Update Rollup, use moduleSideEffects flag diff --git a/packages/dev-server-rollup/src/createRollupPluginContextAdapter.ts b/packages/dev-server-rollup/src/createRollupPluginContextAdapter.ts index 161d2f5f6..f0936148e 100644 --- a/packages/dev-server-rollup/src/createRollupPluginContextAdapter.ts +++ b/packages/dev-server-rollup/src/createRollupPluginContextAdapter.ts @@ -38,6 +38,7 @@ export function createRollupPluginContextAdapter< isEntry: false, isExternal: false, isIncluded: false, + hasModuleSideEffects: false, moduleSideEffects: false, syntheticNamedExports: false, meta: pluginMetaPerModule.get(id) ?? {}, diff --git a/packages/dev-server-rollup/src/rollupAdapter.ts b/packages/dev-server-rollup/src/rollupAdapter.ts index c5b494dcb..fcac5f77e 100644 --- a/packages/dev-server-rollup/src/rollupAdapter.ts +++ b/packages/dev-server-rollup/src/rollupAdapter.ts @@ -295,7 +295,7 @@ export function rollupAdapter( if (typeof result === 'string') { return { body: result, type: 'js' }; } - if (typeof result?.code === 'string') { + if (result != null && typeof result?.code === 'string') { savePluginMeta(filePath, result); return { body: result.code, type: 'js' }; }