Conditionally support NullBooleanField #250
Conversation
ashiazed
force-pushed
the
null_boolean_fields
branch
from
1c70f13
to
88318e3
Compare
ashiazed
force-pushed
the
null_boolean_fields
branch
from
88318e3
to
2e47a15
Compare
|
I added an entry to the changelog |
| @@ -228,7 +228,7 @@ def save(self, *args, **kwargs): | |||
|
|
|||
| class Classroom(models.Model): | |||
| students = models.ManyToManyField(Person, null=True) | |||
| active = models.NullBooleanField() | |||
There was a problem hiding this comment.
@berinhard Since we would still technically support NullBooleanField until model_bakery no longer supports Django < 4.0, would it be okay if there were no test models with this field type? Or should there be conditional test models to make sure everything still works?
There was a problem hiding this comment.
I'd like to say yes but our test requirements use latest Django and as soon as we are on 4.0 we won't be able to import NullBooleanField. Should we add this as a custom field and include it that way?
There was a problem hiding this comment.
I don't think we need such type of safety checks. In the past, with other deprecated fields, we did the same strategy as @ashiazed did: use ImportError and don't worry about it until bakery also drops support for that field.
There was a problem hiding this comment.
This looks fine! Thanks @ashiazed!
@timjklein36 I'll merge this since you also approved the changes. About your consideration on @amureki work on #236, it's still on draft. So we can merge this PR and introduce adaptations over there.
| @@ -228,7 +228,7 @@ def save(self, *args, **kwargs): | |||
|
|
|||
| class Classroom(models.Model): | |||
| students = models.ManyToManyField(Person, null=True) | |||
| active = models.NullBooleanField() | |||
There was a problem hiding this comment.
I don't think we need such type of safety checks. In the past, with other deprecated fields, we did the same strategy as @ashiazed did: use ImportError and don't worry about it until bakery also drops support for that field.
Conditionally support
NullBooleanFielduntil the minimum supported version is Django 4.It has been deprecated since Django 3.1.
This will ensure passing tests when the upgrade to Django4 happens.
Swap to using
BooleanFieldwithnull=Truein the tests, it has been supported since Django.2.0 and model bakery uses Django2.2 as a minimum so all is clear.