From 971d93594bffcfce1a4c525668e2486ebc9fd3fd Mon Sep 17 00:00:00 2001 From: Benjamin Petersen Date: Sun, 10 Oct 2021 10:44:21 -0400 Subject: [PATCH 1/2] Fix typo --- docs/source/basic_usage.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/source/basic_usage.rst b/docs/source/basic_usage.rst index 8ba98d45..e5c7a743 100644 --- a/docs/source/basic_usage.rst +++ b/docs/source/basic_usage.rst @@ -218,7 +218,7 @@ It also works with ``prepare``: The ``make`` method also accepts a parameter ``_bulk_create`` to use Django's `bulk_create `_ method instead of calling ``obj.save()`` for each created instance. -**Disclaimer**: Django's ``bulk_create`` does not updates the created object primary key as explained in their docs. Because of that, there's no way for model-bakery to avoid calling ``save`` method for all the foreign keys. +**Disclaimer**: Django's ``bulk_create`` does not update the created object primary key as explained in their docs. Because of that, there's no way for model-bakery to avoid calling ``save`` method for all the foreign keys. So, for example, if you're trying to create 20 instances of a model with a foreign key using ``_bulk_create`` this will result in 21 queries (20 for each foreign key object and one to bulk create your 20 instances). From 145ba6db31b3366d48f118515eaa75d25b6ce2c2 Mon Sep 17 00:00:00 2001 From: Benjamin Petersen Date: Wed, 20 Oct 2021 20:36:58 -0500 Subject: [PATCH 2/2] Update Changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f0b437e0..1dc90cf1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/). ### Added ### Changed +- Fix a simple typo in `bulk_create` disclaimer in docs ### Removed