Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #245

Merged
merged 2 commits into from Oct 25, 2021
Merged

Fix typo #245

merged 2 commits into from Oct 25, 2021

Conversation

bnjmn
Copy link
Contributor

@bnjmn bnjmn commented Oct 10, 2021

Just a simple typo in docs.

timjklein36
timjklein36 requested changes Oct 11, 2021
View reviewed changes
Copy link
Collaborator

@timjklein36 timjklein36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bnjmn, thanks for your contribution!

Don't forget to add an update to the CHANGELOG.md file (do a search through the file for other examples of changes with a similar nature).

timjklein36
timjklein36 approved these changes Oct 21, 2021
View reviewed changes
Copy link
Collaborator

@timjklein36 timjklein36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@amureki amureki merged commit b339c37 into model-bakers:main Oct 25, 2021
@bnjmn bnjmn deleted the patch-1 branch November 3, 2021 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timjklein36 timjklein36 timjklein36 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bnjmn @timjklein36 @amureki