Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to python 3.10 #244

Merged
merged 1 commit into from Oct 29, 2021
Merged

Conversation

jairhenrique
Copy link
Contributor

@jairhenrique jairhenrique commented Oct 9, 2021

Configure CI to run tests on python 3.10.

@timjklein36
Copy link
Collaborator

@jairhenrique Thank you for your effort on contributing to the project!

I have a couple of comments:

  • First, please add a description to your PR so that the reviewers and other contributors can understand the scope of the changes and your intent.
  • Since some of the file changes in this PR have only formatting related changes, please try to limit the changes to only that which affect the feature/issue at hand. Specifically, the changes to the following files should be reverted, since they do not contribute any meaningful change in behavior:
    • .github/dependabot.yml
    • .github/workflows/changelog.yml
  • Some other files with semantic updates (3.9 to 3.10) contain other unnecessary formatting changes (for example, introducing quotes around the version numbers). Please try to retain the original formatting in these files so that the history only shows meaningful changes, instead of many style/formatting ones.

@jairhenrique jairhenrique force-pushed the python310 branch 6 times, most recently from c0460ae to 6241a53 Compare October 11, 2021 13:23
@jairhenrique
Copy link
Contributor Author

@timjklein36 the config of my code editor auto formats files, sorry for that.

If I put 3.10 whitout quotes, github actions interprets as 3.1 version.

@timjklein36
Copy link
Collaborator

@jairhenrique That makes sense, actually, because of how yaml handles numbers and text. Thanks for the clarification on that.

Copy link
Collaborator

@timjklein36 timjklein36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one minor update to the wording in the CHANGELOG would be great.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@berinhard berinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@berinhard berinhard merged commit 425eabd into model-bakers:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants