Fix #298 -- create m2m when using _bulk_create=True
#354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amureki
force-pushed
the
issues/298/bulk-create-for-m2m
branch
2 times, most recently
from
540ad16
to
e0b7632
Compare
M2M lookups are adding up to the query count, we need to adjust tests to that.
amureki
force-pushed
the
issues/298/bulk-create-for-m2m
branch
from
e0b7632
to
095ace0
Compare
|
@model-bakers/core would love to get your opinion here. I solved the original issue, but it adds extra queries to resolve M2M relations (which I expected). However, due to QuerySet.bulk_create not returning pks in old SQLite versions (and Django < 4.0), there is an extra step that adds even more queries (however, I limited it to not affect Django 4.0+ users). The other option would be to explicitly say that we are not supporting M2M properly in QuerySet.bulk_create, which is also not desirable... |
timjklein36
approved these changes
Oct 17, 2022
Co-authored-by: Tim Klein <timjklein36@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Extending logic of
_save_related_objsthat was added in #206.This is optimized because of
bulk_createuse on through model, but it is still quite heavy on queries.I had to switch to Ubuntu 22 in CI to upgrade default SQLite version which supports returning pks in bulk create operations.
PR Checklist