Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#322] Fix seq for timezone-aware start value #353

Merged
merged 2 commits into from Oct 14, 2022
Merged

[#322] Fix seq for timezone-aware start value #353

merged 2 commits into from Oct 14, 2022

Conversation

timjklein36
Copy link
Collaborator

Fixes #322. Allows seq to properly increment from a timezone-aware starting datetime.

PR Checklist

@timjklein36
[issue-322] seq increment datetime matching tz-awareness of start date
029adf4 
- This also introduces a test case (additional assert in existing test
  method) to cover the regression
@timjklein36 timjklein36 requested a review from a team October 13, 2022 21:41
@timjklein36 timjklein36 self-assigned this Oct 13, 2022
berinhard
berinhard approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@berinhard berinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @timjklein36!!! This looks good to me.

@berinhard berinhard merged commit b90253b into model-bakers:main Oct 14, 2022
amureki added a commit that referenced this pull request Oct 24, 2022
@amureki
Bump 1.9.0
951271c 
- Fixed a bug with `seq` being passed a tz-aware start value [PR #353](#353)
- Create m2m when using `_bulk_create=True` [PR #354](#354)
- [dev] Use official postgis docker image in CI [PR #355](#355)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berinhard berinhard berinhard approved these changes

Assignees

@timjklein36 timjklein36

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

seq doesn't work for timezone aware datetime objects
2 participants
@timjklein36 @berinhard