Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #349 -- subtract lists in Baker.get_fields() instead of casting to set #352

Merged
merged 3 commits into from Oct 13, 2022

Conversation

amureki
Copy link
Collaborator

@amureki amureki commented Oct 11, 2022

No description provided.

@amureki amureki self-assigned this Oct 11, 2022
@amureki
Copy link
Collaborator Author

amureki commented Oct 11, 2022

@model-bakers/core what do you think of such change?
I was digging the history and found that get_related was added to get related fields except M2M:
berinhard/model_mommy@c5fd18a

However, this functionality did change later, and we are including M2M fields now again - which in the end duplicates Django API:
https://github.com/django/django/blob/f30c7e381c94f41d361877d8a3e90f8cfb391709/django/db/models/options.py#L604-L625

So, I removed it completely along with subtracting lists refactoring to fix #349

@amureki amureki marked this pull request as ready for review October 12, 2022 06:59
@amureki amureki requested a review from a team October 12, 2022 06:59
Copy link
Collaborator

@timjklein36 timjklein36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@amureki amureki merged commit 2fdbd1e into main Oct 13, 2022
@amureki amureki deleted the issues/349/faker branch October 13, 2022 19:55
@amureki amureki changed the title Fix #349 -- substract lists in Baker.get_fields() instead of casting to set Fix #349 -- subtract lists in Baker.get_fields() instead of casting to set Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants