Do not bypass many-to-many related fields. #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berinhard
commented
Mar 31, 2022
Comment on lines
+234
to
+241
| class ClassroomM2MRelated(models.Model): | ||
| """ | ||
| This model was created in order to reproduce the scenario described | ||
| at issue 248 that is: a model with a M2M field (Classroom) being also used | ||
| as a M2M field from another model (ClassroomM2MRelated) | ||
| """ | ||
|
|
||
| related_classrooms = models.ManyToManyField(Classroom) |
There was a problem hiding this comment.
Just by adding this model I was able to break 2 tests with the same error message as described by @a-edakin in #248. Here's the traceback of the failing tests to prove it:
______________________________________________________________ TestFillNullsTestCase.test_create_nullable_many_to_many_if_flagged_and_fill_optional _______________________________________________________________
tests/test_baker.py:621: in test_create_nullable_many_to_many_if_flagged_and_fill_optional
classroom = baker.make(models.Classroom, make_m2m=True, _fill_optional=True)
model_bakery/baker.py:133: in make
return baker.make(
model_bakery/baker.py:389: in make
return self._make(**params)
model_bakery/baker.py:457: in _make
self.model_attrs[field.name] = self.generate_value(
model_bakery/baker.py:660: in generate_value
if field.has_default() and field.name not in self.rel_fields:
E AttributeError: 'ManyToManyRel' object has no attribute 'has_default'
________________________________________________________ TestFillNullsTestCase.test_nullable_many_to_many_is_not_created_if_not_flagged_and_fill_optional _________________________________________________________
tests/test_baker.py:627: in test_nullable_many_to_many_is_not_created_if_not_flagged_and_fill_optional
classroom = baker.make(models.Classroom, make_m2m=False, _fill_optional=True)
model_bakery/baker.py:133: in make
return baker.make(
model_bakery/baker.py:389: in make
return self._make(**params)
model_bakery/baker.py:457: in _make
self.model_attrs[field.name] = self.generate_value(
model_bakery/baker.py:660: in generate_value
if field.has_default() and field.name not in self.rel_fields:
E AttributeError: 'ManyToManyRel' object has no attribute 'has_default'
timjklein36
approved these changes
Mar 31, 2022
|
Thanks @timjklein36 for the lightning speed review ⚡ ⚡ ⚡ |
This was referenced Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #248
The issue has all the important discussion on the reasons behind this PR. But the if condition was bypassing related m2m and, thus, considering them as regular fields of the model.