Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max Django version requirement syntax #251

Merged

Conversation

ashiazed
Copy link
Contributor

@ashiazed ashiazed commented Oct 23, 2021

Add missing comma so that Django 4 is not installed by default.

Fixes #249

@ashiazed ashiazed force-pushed the fix-django-requirements-max-version branch from 288693c to 5f40d72 Compare October 26, 2021 02:56
Copy link
Collaborator

@timjklein36 timjklein36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another contribution!

Copy link
Member

@berinhard berinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@berinhard berinhard merged commit 3c4c415 into model-bakers:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Following contributor instructions yields failing tests due to missing comma in requirements.txt
4 participants