Improve seq helper #247
Merged
Improve seq helper #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timjklein36
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
One minor comment about the function prefix. Otherwise, this looks good to me! Thanks for another contribution @jairhenrique!
jairhenrique
force-pushed
the
improve_seq
branch
from
b090986
to
1da8ccb
Compare
jairhenrique
force-pushed
the
improve_seq
branch
from
1da8ccb
to
a7274b3
Compare
timjklein36
reviewed
Oct 12, 2021
| @@ -10,6 +10,8 @@ | |||
|
|
|||
| from .timezone import tz_aware | |||
|
|
|||
| __all__ = ["import_from_str", "get_calling_module", "seq"] | |||
There was a problem hiding this comment.
Since this is not strictly necessary, I think it should not be introduced. The rest of the model_bakery files do not do this (except for gis.py for some reason).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increment_bywhen value is an instance ofdatetime.