Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py.typed export per PEP 561 #158

Merged
merged 4 commits into from Mar 31, 2022

Conversation

maroux
Copy link
Contributor

@maroux maroux commented Mar 3, 2021

Add py.typed file and export type annotations per PEP 561 so that type testing tools like mypy can actually verify types when using model_bakery.

No new test added for this change and I don't think there's any documentation necessary but let me know if something needs to be added.

Copy link
Member

@berinhard berinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maroux thanks for opening this PR!

It looks good to me but we can't merge it until you update the Changelog file with your change. Can you do that, please? Feel free to add a link to the PEP 561 description in the Changelog alongside.

Thanks a lot!!!

@knyghty
Copy link
Contributor

knyghty commented Jan 21, 2022

Hi, it would be nice to have this.

@maroux, are you able to add the changelog entry?

If not, @berinhard, should I open a new PR to supersede this?

@maroux
Copy link
Contributor Author

maroux commented Jan 21, 2022

@knyghty Done.

@maroux maroux requested a review from berinhard January 21, 2022 16:45
Copy link
Member

@berinhard berinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and sorry for the late review =)

@berinhard berinhard merged commit 99d4f52 into model-bakers:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants