New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose more mockk projects as API dependencies #905
Conversation
Here's the dependencies in the <dependencies>
<dependency>
<groupId>io.mockk</groupId>
<artifactId>mockk-dsl</artifactId>
<version>1.12.8-SNAPSHOT</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>io.mockk</groupId>
<artifactId>mockk-agent</artifactId>
<version>1.12.8-SNAPSHOT</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>io.mockk</groupId>
<artifactId>mockk-agent-api</artifactId>
<version>1.12.8-SNAPSHOT</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>org.jetbrains.kotlin</groupId>
<artifactId>kotlin-stdlib-jdk8</artifactId>
<version>1.7.10</version>
<scope>runtime</scope>
</dependency>
</dependencies>
</project> And for <dependencyManagement>
<dependencies>
<dependency>
<groupId>org.jetbrains.kotlinx</groupId>
<artifactId>kotlinx-coroutines-bom</artifactId>
<version>1.6.4</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>
<dependencies>
<dependency>
<groupId>io.mockk</groupId>
<artifactId>mockk</artifactId>
<version>1.12.8-SNAPSHOT</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>io.mockk</groupId>
<artifactId>mockk-agent-api</artifactId>
<version>1.12.8-SNAPSHOT</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>io.mockk</groupId>
<artifactId>mockk-agent-android</artifactId>
<version>1.12.8-SNAPSHOT</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.jetbrains.kotlin</groupId>
<artifactId>kotlin-stdlib-jdk8</artifactId>
<version>1.7.10</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.jetbrains.kotlinx</groupId>
<artifactId>kotlinx-coroutines-core</artifactId>
<scope>runtime</scope>
</dependency>
</dependencies> |
LGTM. @SimonMarquis can you please try deploying this branch to your local maven repo and see if it fixes your issue? |
I think it's a mistake that |
Removing the Coroutines dependencies from <dependencies>
<dependency>
<groupId>io.mockk</groupId>
<artifactId>mockk</artifactId>
<version>1.12.8-SNAPSHOT</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>io.mockk</groupId>
<artifactId>mockk-agent-api</artifactId>
<version>1.12.8-SNAPSHOT</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>io.mockk</groupId>
<artifactId>mockk-agent-android</artifactId>
<version>1.12.8-SNAPSHOT</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.jetbrains.kotlin</groupId>
<artifactId>kotlin-stdlib-jdk8</artifactId>
<version>1.7.10</version>
<scope>compile</scope>
</dependency>
</dependencies> |
56b30de works fine on my setup 👍 |
👋 Hi, is there any ETA for this fix to land in the 1.12.8? |
Just released v1.12.8, sorry about the delay. |
🚀 awesome thanks! |
fix #903
maybe helps #891 #889, so the
mockk-jvm
workaround isn't needed any more?