New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump kotlin 1.7.10, and language level to 1.5 #850
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raibaz
reviewed
Jul 20, 2022
aSemy
changed the title
bump kotlin 1.7.10, and language level to 1.7
bump kotlin 1.7.10, and language level to 1.5
Jul 20, 2022
aSemy
commented
Jul 21, 2022
Comment on lines
+57
to
+63
when (outcome) { | ||
is VerificationResult.OK -> if (inverse) { | ||
val callsReport = VerificationHelpers.formatCalls(outcome.verifiedCalls) | ||
throw AssertionError("Inverse verification failed.\n\nVerified calls:\n$callsReport") | ||
} | ||
} else { | ||
when (outcome) { | ||
is VerificationResult.Failure -> throw AssertionError("Verification failed: ${outcome.message}") | ||
is VerificationResult.Failure -> if (!inverse) { | ||
throw AssertionError("Verification failed: ${outcome.message}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a little bit of refactoring here because having two 'when' statements seemed odd. I think it's clearer now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the version of Kotlin to the latest version, 1.7.10.
I also set the API and language levels to 1.7. I have NO idea if this is the best choice! On one hand, I think it's best to 'go big or go home' - this kind of change only needs to be done once, and now mockk is at a high language level that will be available for years. On the other hand, perhaps maintaining and providing as wide compatibility is best.discussed below, will bump to 1.5I'm making this change to help work related to supporting value classes - see #152 and #849
Summary
toUpperCase()
->uppercase()
,toLowerCase()
->lowercase()
when
branches exhaustivehttp
URLs in the docs tohttps
, since I spotted them.