Moves MockKExtension
's unmockkAll
behavior to the afterAll
callback
#739
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is motivated by the comment I've dropped at #142 (comment).
MockKExtension
is callingunmockkAll
by default at the end of each test, which interferes with the@TestInstance(TestInstance.Lifecycle.PER_CLASS)
configuration.We discovered this issue after enabling
junit.extensions.autodetection.enabled=true
(by other rules, not this one) and all tests with cached mocks (per instance) started to fail because of the reset.This PR moves the
unmockkAll
behavior to theafterAll
callback, and also introduces a new@KeepMocks
(and amockk.junit.extension.keepmocks
property) to allow disabling just this feature while keeping the others ofMockKExtension
.