Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove reduntant ValueClassSupport in JVM #653

Merged
merged 1 commit into from Jun 30, 2021

Conversation

hrach
Copy link
Contributor

@hrach hrach commented Jun 30, 2021

The code will then reuses the jvm-agent's ValueClassSupport.

I do not understand much the relations between these modules and so but removing this seems to work and fix my issue when building android instrumentation tests:

> A failure occurred while executing com.android.build.gradle.internal.tasks.CheckDuplicatesRunnable
   > Duplicate class io.mockk.ValueClassSupportKt found in modules mockk-agent-jvm-caea7cce8ac300991b8cf182e5d3524a4bc27ffd (com.github.hrach.mockk:mockk-agent-jvm:caea7cce8ac300991b8cf182e5d3524a4bc27ffd) and mockk-jvm-caea7cce8ac300991b8cf182e5d3524a4bc27ffd (com.github.hrach.mockk:mockk-jvm:caea7cce8ac300991b8cf182e5d3524a4bc27ffd)

The code will reuses jvm-agent's one
@Raibaz Raibaz merged commit a9daae9 into mockk:master Jun 30, 2021
@dawidhyzy
Copy link

dawidhyzy commented Jul 13, 2021

My build fails with:
Duplicate class io.mockk.ValueClassSupportKt found in modules jetified-mockk-agent-android-1.12.0-runtime (io.mockk:mockk-agent-android:1.12.0) and jetified-mockk-agent-jvm-1.12.0 (io.mockk:mockk-agent-jvm:1.12.0)

@davidmigloz
Copy link

Same issue

@Syrou
Copy link

Syrou commented Oct 12, 2021

Same, for version 1.12.0

@hrach
Copy link
Contributor Author

hrach commented Oct 12, 2021

Hi guys, if you have any issue, find open one or open new. Commented merged PR doesn't properly expose the issue to maintainers.

@fpitpit
Copy link

fpitpit commented Dec 2, 2021

I've got the same bug with 1.12.1

@andreottielisa
Copy link

I've got the same bug with version 1.12.4

androidTestImplementation "io.mockk:mockk-android:1.12.4"
androidTestImplementation "io.mockk:mockk-agent-jvm:1.12.4"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants