Bug: Verifications fail with Missing calls inside verify { ... } block when ran on CLI but pass in IDE

[mp911de]

Prerequisites

Please answer the following questions for yourself before submitting an issue.

• I am running the latest version
• I checked the documentation and found no answer
• I checked to make sure that this issue has not already been filed

Expected Behavior

Verification is properly evaluated.

Current Behavior

The test fails with: Missing calls inside verify { ... } block

Failure Information (for bugs)

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

1. See code
2. Run CriteriaExtensionsUnitTests

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

• MockK version: 1.9.1
• OS: MacOS 10.14.2
• Kotlin version: tested on 1.3.11 and 1.3.21
• JDK version: JRE 1.8.0_121-b13
• JUnit version: 4.12
• Type of test: JUnit 4 test

Stack trace

io.mockk.MockKException: Missing calls inside verify { ... } block.
	at org.springframework.data.cassandra.core.query.CriteriaExtensionsUnitTests.inValues(varags) extension should support nullable values(CriteriaExtensionsUnitTests.kt:66)

Minimal reproducible code (the gist of this issue)

class CriteriaExtensionsUnitTests {

	val criteria = mockk<Criteria>(relaxed = true)

	@Test
	fun `inValues(Collection) extension should call its Java counterpart`() {

		val c = listOf("foo", "bar")

		criteria.inValues(c)

		verify { criteria.`in`(c) }
	}
}

/**
 * Extension for [Criteria. in] providing an `inValues` alias since `in` is a reserved keyword in Kotlin.
 */
fun <T : Any?> Criteria.inValues(c: Collection<T>): Criteria = `in`(c)

public class Criteria {
	public Criteria in(Collection<?> values) {
		return this;
	}
}

See also: https://github.com/spring-projects/spring-data-cassandra/blob/master/spring-data-cassandra/src/test/kotlin/org/springframework/data/cassandra/core/query/CriteriaExtensionsUnitTests.kt#L75-L81

[oleksiyp]

Thanks for the report. Will check

[oleksiyp]

Spent some time on this issue. Instrumention is OK. Turned off parallel testing , but that did not help. In trace logs call doesn't get intercepted. Probably something related to class loading. Will spend more time on weekends

[mp911de]

Can this be related to Surefire 2.22.1?

[oleksiyp]

Very probable, as JUnit 4.12 is widely used and no other things to interact with. ByteBuddy seems to be working as one test passing and transformed classes are OK

[oleksiyp]

Seems problem appears when building with 2.19 and above Surefire plugin.

[oleksiyp]

I experimented a lot with this error.

Turned on debugging, double-checked all the maps inside of mockk, e.t.c. Nothing too suspicious. Looks like not always instrumentation take place at the moment it is requested, maybe not for all threads at a time, or maybe there is a race condition in mockk code. Actually I am starting to understand it better, but let's see. The problem now is to reproduce it without surefire.

Currently, all my achievement in reproduction and differentiation is that I know if I put sleep(500) after mock intialization it won't fail.

[oleksiyp]

Good news 😄

I reproduced it.

[oleksiyp]

@mp911de please try the same test with version 1.9.2 or 1.9.2.kotlin12. Thanks

[mp911de]

Thanks a lot. The fix addressed the issue.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If you are sure that this issue is important and should not be marked as stale just ask to put an important label.