Kotlin version configured from GitHub Actions workflow is not correctly applied

[SimonMarquis]

CI uses the following matrix to test Kotlin versions:

mockk/.github/workflows/gradle.yml

Line 20 in 6c7a06c

kotlin-version: [ 1.5.31, 1.6.21, 1.7.22, 1.8.0 ]

and propagate them as Gradle project properties:

mockk/.github/workflows/gradle.yml

Line 41 in 6c7a06c

-Pkotlin.version=${{ matrix.kotlin-version }}

MockK uses this property here:

mockk/buildSrc/src/main/kotlin/buildsrc/config/Deps.kt

Line 6 in 6c7a06c

fun Project.kotlinVersion() = findProperty("kotlin.version")?.toString() ?: Deps.Versions.kotlinDefault

but this method is unused in this project.
And therefore I suspect all jobs are using the same Kotlin version.

---

Also, I tried to run the same command as in the workflow but with an invalid Kotlin version, and it still ran the tests sucessfully:

gradlew check --stacktrace -Pkotlin.version=0.0.0 -Pkotlin.ir.enabled=true -PjavaToolchainTestVersion=17

[SimonMarquis]

kotlin.ir.enabled seems to be no longer used as well.

[aSemy]

Good spot! Removing kotlin.ir.enabled would really help with CI as it would half the number of tests.

The dependencies versions handling was never tidied up after the big refactoring in #855

I've made a PR - let's see if the tests pass...

[SimonMarquis]

Kotlin-IR will be removed in #1153, but the main issue persist: Project.kotlinVersion() is never used.

[SimonMarquis]

@Raibaz is this really meant to be used on CI? I'm wondering what was this trying to achieve as we can only ship a single artifact, targeting a single Kotlin version 🤔

[Raibaz]

Yep it was meant to be used on CI to make sure master was building fine and tests were passing against several different Kotlin versions; specifically the tests in clientTests, which depend on MockK as if they were a client project.

It is true we ship a single artifact targeting a single Kotlin version, but we also want to ensure backwards compatibility with older versions, and that was what I was trying to ensure on CI.

Usage of Project.kotlinVersion() must have been mistakenly dropped when we refactored gradle files to .kts, as @aSemy mentioned, see here.

This being said, we can probably live without kotlin.ir.enabled since the IR is now enabled by default on all latest versions, but I'd still like CI to build against at least a few different versions (which is not happening now)

[SimonMarquis]

Understood. Then maybe we should simply take advantage of the Kotlin BoM and only provide the version once. I'll try to come up with something unless you have a specific solution in mind.

[Raibaz]

I don't have a specific solution in mind, so any help on this (as on any other topic) is greatly appreciated <3