From b98581186a3f7d4c575d81e941b389c4dd3a0597 Mon Sep 17 00:00:00 2001 From: Adam <897017+aSemy@users.noreply.github.com> Date: Thu, 25 Aug 2022 00:19:17 +0200 Subject: [PATCH 1/3] try reverting the minSdk to 23 --- .../kotlin/buildsrc/convention/android-application.gradle.kts | 2 +- .../main/kotlin/buildsrc/convention/android-library.gradle.kts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/buildSrc/src/main/kotlin/buildsrc/convention/android-application.gradle.kts b/buildSrc/src/main/kotlin/buildsrc/convention/android-application.gradle.kts index 09f064aed..db9f22d76 100644 --- a/buildSrc/src/main/kotlin/buildsrc/convention/android-application.gradle.kts +++ b/buildSrc/src/main/kotlin/buildsrc/convention/android-application.gradle.kts @@ -34,7 +34,7 @@ android { } defaultConfig { - minSdk = 26 + minSdk = 23 targetSdk = 32 } diff --git a/buildSrc/src/main/kotlin/buildsrc/convention/android-library.gradle.kts b/buildSrc/src/main/kotlin/buildsrc/convention/android-library.gradle.kts index 3f3e573e7..11ee3d795 100644 --- a/buildSrc/src/main/kotlin/buildsrc/convention/android-library.gradle.kts +++ b/buildSrc/src/main/kotlin/buildsrc/convention/android-library.gradle.kts @@ -32,7 +32,7 @@ android { } defaultConfig { - minSdk = 26 + minSdk = 23 targetSdk = 32 } From 15928a744578bf05f4bde5d683b2e7ff32978989 Mon Sep 17 00:00:00 2001 From: Adam <897017+aSemy@users.noreply.github.com> Date: Thu, 25 Aug 2022 00:40:08 +0200 Subject: [PATCH 2/3] change GHA Android test to test the minsdk version --- .github/workflows/gradle.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/gradle.yml b/.github/workflows/gradle.yml index e35730e1f..59bcb814c 100644 --- a/.github/workflows/gradle.yml +++ b/.github/workflows/gradle.yml @@ -56,7 +56,7 @@ jobs: runs-on: macos-latest strategy: matrix: - api-level: [ 26, 28, 29 ] + api-level: [ 23, 29 ] # minSdk is set to 23 in the buildSrc convention plugins. fail-fast: false # in case one API-level fails, we still want to see results from others timeout-minutes: 30 steps: From c7ac7f27a3e1122cc96f325f4f7abf133ffacdc6 Mon Sep 17 00:00:00 2001 From: Adam <897017+aSemy@users.noreply.github.com> Date: Thu, 25 Aug 2022 23:31:37 +0200 Subject: [PATCH 3/3] set minSdk to 21 --- .github/workflows/gradle.yml | 2 +- .../kotlin/buildsrc/convention/android-application.gradle.kts | 2 +- .../main/kotlin/buildsrc/convention/android-library.gradle.kts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/gradle.yml b/.github/workflows/gradle.yml index 59bcb814c..3782c935c 100644 --- a/.github/workflows/gradle.yml +++ b/.github/workflows/gradle.yml @@ -56,7 +56,7 @@ jobs: runs-on: macos-latest strategy: matrix: - api-level: [ 23, 29 ] # minSdk is set to 23 in the buildSrc convention plugins. + api-level: [ 21, 29 ] # The minSdk and targetSdk versions set for MockK Android projects fail-fast: false # in case one API-level fails, we still want to see results from others timeout-minutes: 30 steps: diff --git a/buildSrc/src/main/kotlin/buildsrc/convention/android-application.gradle.kts b/buildSrc/src/main/kotlin/buildsrc/convention/android-application.gradle.kts index db9f22d76..440f7d0c8 100644 --- a/buildSrc/src/main/kotlin/buildsrc/convention/android-application.gradle.kts +++ b/buildSrc/src/main/kotlin/buildsrc/convention/android-application.gradle.kts @@ -34,7 +34,7 @@ android { } defaultConfig { - minSdk = 23 + minSdk = 21 targetSdk = 32 } diff --git a/buildSrc/src/main/kotlin/buildsrc/convention/android-library.gradle.kts b/buildSrc/src/main/kotlin/buildsrc/convention/android-library.gradle.kts index 11ee3d795..8d65275b4 100644 --- a/buildSrc/src/main/kotlin/buildsrc/convention/android-library.gradle.kts +++ b/buildSrc/src/main/kotlin/buildsrc/convention/android-library.gradle.kts @@ -32,7 +32,7 @@ android { } defaultConfig { - minSdk = 23 + minSdk = 21 targetSdk = 32 }