Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless thrown exception from constructor #2732

Merged
merged 1 commit into from Aug 15, 2022
Merged

Remove useless thrown exception from constructor #2732

merged 1 commit into from Aug 15, 2022

Conversation

Thibstars
Copy link
Contributor

@Thibstars Thibstars commented Aug 15, 2022

This PR removes a thrown Exception from a constructor, since it will never be thrown. Also a minor grammar fix in javadoc.

If a constructor only has variable assignment(s), then an exception will never be thrown, thus the constructor must not include any 'thrown' clauses.

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

@TimvdLippe TimvdLippe merged commit 2ded10e into mockito:main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants