Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for sealed types #2392

Merged
merged 1 commit into from Aug 19, 2021
Merged

Add checks for sealed types #2392

merged 1 commit into from Aug 19, 2021

Conversation

raphw
Copy link
Member

@raphw raphw commented Aug 17, 2021

Sealed types do not allow for mocks as the sealing property is unmodifiable even by retransformation. This means sealed classes can only be mocked if they are real inline mocks. We should produce proper error messages for this to avoid user confusion.

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #2392 (8e02622) into main (28020c0) will decrease coverage by 0.05%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2392      +/-   ##
============================================
- Coverage     84.74%   84.68%   -0.06%     
- Complexity     2791     2794       +3     
============================================
  Files           328      329       +1     
  Lines          8490     8510      +20     
  Branches       1026     1031       +5     
============================================
+ Hits           7195     7207      +12     
- Misses         1017     1021       +4     
- Partials        278      282       +4     
Impacted Files Coverage Δ
...al/creation/bytebuddy/InlineBytecodeGenerator.java 83.54% <33.33%> (-0.73%) ⬇️
...creation/bytebuddy/SubclassByteBuddyMockMaker.java 67.56% <40.00%> (-2.44%) ⬇️
...ckito/internal/creation/bytebuddy/TypeSupport.java 78.57% <78.57%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28020c0...8e02622. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants