Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructor dispatch #2021

Merged
merged 2 commits into from Aug 24, 2020
Merged

Constructor dispatch #2021

merged 2 commits into from Aug 24, 2020

Conversation

raphw
Copy link
Member

@raphw raphw commented Aug 24, 2020

Fixes recursive constructor invocation.
Avoids reflective access warning when using instrumentation-based member accessor.

@raphw raphw merged commit 76a91f0 into release/3.x Aug 24, 2020
@@ -12,3 +12,7 @@ tasks.javadoc.enabled = false
//required by the "StressTest.java" and "OneLinerStubStressTest.java"
test.maxHeapSize = "256m"
retryTest.maxHeapSize = "256m"

test {
jvmArgs '--illegal-access=debug'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means that the build will now fail when an Illegal Access is performed? Nice!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will log it in more detail but fail would be the much more sensible option. Weird I did not think of it, that's of course a much better value...

@TimvdLippe
Copy link
Contributor

I think something has gone wrong with this PR. Travis is quite red after this PR: https://travis-ci.org/github/mockito/mockito/builds Example broken build: https://travis-ci.org/github/mockito/mockito/builds/720600848

Seems like this PR was merged, but Travis hadn't finished yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants