Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade byte buddy to 1.10.5 #1842

Merged
merged 1 commit into from Dec 12, 2019

Conversation

villesau
Copy link
Contributor

@villesau villesau commented Dec 11, 2019

check list

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

Fixes #1841

Byte buddy had a bug that prevented running tests in IntelliJ that's now fixed.

@villesau villesau changed the title update byte-buddy to 1.10.5 Upgrade byte buddy to 1.10.5 Dec 11, 2019
@codecov-io
Copy link

codecov-io commented Dec 11, 2019

Codecov Report

Merging #1842 into release/3.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release/3.x    #1842   +/-   ##
==============================================
  Coverage          86.64%   86.64%           
  Complexity          2507     2507           
==============================================
  Files                314      314           
  Lines               6613     6613           
  Branches             829      829           
==============================================
  Hits                5730     5730           
  Misses               682      682           
  Partials             201      201

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49c3b4f...38bee9a. Read the comment docs.

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TimvdLippe TimvdLippe merged commit fe1141b into mockito:release/3.x Dec 12, 2019
@villesau villesau deleted the update-bytebuddy branch December 12, 2019 08:42
@villesau
Copy link
Contributor Author

@TimvdLippe any chance of releasing this?

@TimvdLippe
Copy link
Contributor

@villesau This has been released on Bintray: https://bintray.com/mockito/maven/mockito-development/3.1.13

@villesau
Copy link
Contributor Author

@TimvdLippe looks like it's still not visible in github releases: https://github.com/mockito/mockito/releases

@TimvdLippe
Copy link
Contributor

Yeah Mockito 3.2.1 was incorrectly tagged. Fixed in 4c29061

@villesau
Copy link
Contributor Author

Great, thanks for the help @TimvdLippe! :)

@villesau
Copy link
Contributor Author

villesau commented Dec 13, 2019

@TimvdLippe one question still: Why it's not released in maven yet? https://mvnrepository.com/artifact/org.mockito/mockito-core/3.2.0

Not a biggie, just wondering.

@TimvdLippe
Copy link
Contributor

epeee pushed a commit to epeee/mockito that referenced this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update byte-buddy to 1.10.5
3 participants