New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1839 : Badge improvements in README.md #1840
Conversation
proski
commented
Dec 5, 2019
•
edited
edited
Use shields.io badge for Bintray, as the Bintray hosted badge shows "Download" and cannot be made to show "Bintray". Split an excessively long line for the first row of badges. Update the alt text for "Release Notes". Non-graphical users would only see a link to the release notes. "Javadoc" was misspelled as "Javadocs". Use HTTPS for all links. Use direct links to the package on Maven Central and Bintray. Use the default color for Javadoc, red looks as an error.
Please compare: |
Codecov Report
@@ Coverage Diff @@
## release/3.x #1840 +/- ##
==============================================
Coverage 86.71% 86.71%
+ Complexity 2492 2489 -3
==============================================
Files 311 311
Lines 6551 6551
Branches 822 822
==============================================
Hits 5681 5681
Misses 674 674
Partials 196 196 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again only 1 nit. Thanks 😄
README.md
Outdated
|
||
[![Release Notes](https://img.shields.io/badge/release%20notes-3.x-yellow.svg)](https://github.com/mockito/mockito/blob/release/3.x/doc/release-notes/official.md) | ||
[![Maven Central](https://img.shields.io/maven-central/v/org.mockito/mockito-core.svg)](https://search.maven.org/artifact/org.mockito/mockito-core/) | ||
[![Bintray](https://img.shields.io/bintray/v/mockito/maven/mockito)](https://bintray.com/mockito/maven/mockito/_latestVersion) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as on the website PR, let's keep this mockito-development
and fix the bug in Shipkit instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I've reverted that change. Sadly, it means that #1839 is not going to be fully fixed by this PR. At least "Download" would become "Bintray", so that users won't expect it to the the download link.
Use shields.io badge for Bintray, as the Bintray hosted badge shows "Download" and cannot be made to show "Bintray". Split an excessively long line for the first row of badges. Update the alt text for "Release Notes". Non-graphical users would only see a link to the release notes. "Javadoc" was misspelled as "Javadocs". Use HTTPS for all links. Use direct links to the package on Maven Central and Bintray. Use the default color for Javadoc, red looks as an error.