Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the tests use mock maker with intended member accessor #2872

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

reta
Copy link
Contributor

@reta reta commented Jan 16, 2023

Make sure the tests use mock maker with intended member accessor
Fixes #2855

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

@reta reta force-pushed the issue-2855 branch 2 times, most recently from bcd7e61 to 5b5fade Compare January 16, 2023 21:16
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2023

Codecov Report

Base: 84.76% // Head: 84.76% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (36ab2f2) compared to base (f4d7c34).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 36ab2f2 differs from pull request most recent head 3d7e0d2. Consider uploading reports for the commit 3d7e0d2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2872   +/-   ##
=========================================
  Coverage     84.76%   84.76%           
- Complexity     2867     2868    +1     
=========================================
  Files           327      327           
  Lines          8780     8784    +4     
  Branches       1068     1068           
=========================================
+ Hits           7442     7446    +4     
- Misses         1064     1065    +1     
+ Partials        274      273    -1     
Impacted Files Coverage Δ
...l/configuration/plugins/DefaultMockitoPlugins.java 92.50% <100.00%> (+0.60%) ⬆️
...internal/configuration/plugins/PluginRegistry.java 100.00% <100.00%> (ø)
...ernal/configuration/plugins/PluginInitializer.java 66.66% <0.00%> (-4.77%) ⬇️
...creation/bytebuddy/SubclassByteBuddyMockMaker.java 50.00% <0.00%> (+2.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@reta reta force-pushed the issue-2855 branch 6 times, most recently from 36ab2f2 to f9e499d Compare January 18, 2023 01:00
@reta reta force-pushed the issue-2855 branch 4 times, most recently from 5620f5c to 298ee9a Compare January 19, 2023 00:40
Signed-off-by: Andriy Redko <drreta@gmail.com>
@reta reta marked this pull request as ready for review January 19, 2023 01:11
@reta reta requested a review from TimvdLippe January 19, 2023 01:11
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Now we know for sure we have covered all cases. Great work once again :)

@TimvdLippe TimvdLippe merged commit 96452fa into mockito:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure the tests use mock maker with intended member accessor
3 participants