Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed use case for non-existent method VerificationWithTimeout#never #2848

Merged

Conversation

cedretaber
Copy link
Contributor

VerificationWithTimeout#never was removed in this commit, but remained in the doc comment.

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

@codecov-commenter
Copy link

Codecov Report

Base: 84.88% // Head: 83.82% // Decreases project coverage by -1.06% ⚠️

Coverage data is based on head (32d4dc5) compared to base (6c92944).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2848      +/-   ##
============================================
- Coverage     84.88%   83.82%   -1.07%     
+ Complexity     2875     2865      -10     
============================================
  Files           327      327              
  Lines          8761     8761              
  Branches       1060     1060              
============================================
- Hits           7437     7344      -93     
- Misses         1047     1137      +90     
- Partials        277      280       +3     
Impacted Files Coverage Δ
...ito/internal/creation/proxy/MethodHandleProxy.java 0.00% <0.00%> (-66.67%) ⬇️
...ByteBuddyCrossClassLoaderSerializationSupport.java 3.48% <0.00%> (-66.28%) ⬇️
...ckito/internal/creation/proxy/ProxyRealMethod.java 14.28% <0.00%> (-42.86%) ⬇️
...ckito/internal/creation/bytebuddy/TypeSupport.java 57.14% <0.00%> (-21.43%) ⬇️
...rnal/creation/bytebuddy/MockMethodInterceptor.java 77.77% <0.00%> (-7.41%) ⬇️
.../creation/bytebuddy/SubclassBytecodeGenerator.java 68.60% <0.00%> (-2.91%) ⬇️
...l/stubbing/answers/AnswerFunctionalInterfaces.java 93.75% <0.00%> (-1.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TimvdLippe TimvdLippe merged commit 7b5b8dd into mockito:main Jan 4, 2023
@cedretaber cedretaber deleted the remove-non-existent-method-use-case branch January 4, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants