Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fix #2765: Add task to download package-list file from java as element-list #2766

Conversation

andrepaschoal
Copy link
Contributor

@andrepaschoal andrepaschoal commented Oct 16, 2022

I think these changes could a fix, or at least part of, for the issue #2765.

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

…/api/package-list inside build dir as javase-6-docs/element-list, move javase/6/docs from links to linksOffline
@andrepaschoal andrepaschoal changed the title issue-2765: add de.undercouch.download plugin, download javase/6/docs… Possible fix #2765: Add task to download package-list file from java as element-list Oct 16, 2022
@andrepaschoal
Copy link
Contributor Author

hey @TimvdLippe, please check if this could a solution for #2765

@andrepaschoal
Copy link
Contributor Author

Per this Java 8 build is going after package-list... let me do something very dumb and hava both element-list and package-list in that dir...

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2022

Codecov Report

Base: 86.18% // Head: 86.18% // No change to project coverage 👍

Coverage data is based on head (129afa4) compared to base (0a9aa26).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2766   +/-   ##
=========================================
  Coverage     86.18%   86.18%           
  Complexity     2831     2831           
=========================================
  Files           320      320           
  Lines          8583     8583           
  Branches       1058     1058           
=========================================
  Hits           7397     7397           
  Misses          905      905           
  Partials        281      281           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrepaschoal
Copy link
Contributor Author

🥳

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, glad that works! A couple of nits and let's make sure the artifact is verified with a shasum to prevent malicious content to be downloaded.

gradle/mockito-core/javadoc.gradle Outdated Show resolved Hide resolved
gradle/mockito-core/javadoc.gradle Outdated Show resolved Hide resolved
gradle/mockito-core/javadoc.gradle Outdated Show resolved Hide resolved
gradle/mockito-core/javadoc.gradle Outdated Show resolved Hide resolved
gradle/mockito-core/javadoc.gradle Outdated Show resolved Hide resolved
…/java-8-docs dir, replace download tasks by a copy folder one
build.gradle Outdated Show resolved Hide resolved
… directly to gradle/mockito-core/java-8-docs
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The smallest fixes are most of the times the best ones 👍 Thanks for the work! Greatly appreciated 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants