Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing errorprone module for 4.5.0 in central as release was done with jdk 8 #2623

Closed
hazendaz opened this issue Apr 20, 2022 · 6 comments · Fixed by #2624
Closed

Missing errorprone module for 4.5.0 in central as release was done with jdk 8 #2623

hazendaz opened this issue Apr 20, 2022 · 6 comments · Fixed by #2624

Comments

@hazendaz
Copy link
Contributor

Error prone module is missing for 4.5.0 and not in the 4.5.0 bom. Looking at the source code changes and release action, it appears jdk 8 was used to release and its ignored unless jdk 11 is used. Can someone check?

@TimvdLippe
Copy link
Contributor

Ah ugh, yes that's a mistake. We will need to update our GitHub actions configuration to run the release job on JDK 11. Do you mind sending us a PR that updates the job matrix to skip the release on JDK 8 and runs it on JDK 11?

@hazendaz
Copy link
Contributor Author

hazendaz commented Apr 20, 2022 via email

@TimvdLippe
Copy link
Contributor

@raphw can you release 4.5.1 on main including #2624? That should fix our ErrorProne artifact.

@raphw
Copy link
Member

raphw commented Apr 21, 2022

Triggered one just now.

@TimvdLippe
Copy link
Contributor

@hazendaz
Copy link
Contributor Author

Thanks @TimvdLippe @raphw for quick turn around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants