Fixes #2281: Make MockedConstruction stubs close on demand

[temp-droid]

MockedConstruction should behave like MockedStatic when we use @mock on it.

Checklist

• Read the contributing guide
• PR should be motivated, i.e. what does it fix, why, and if relevant how
• If possible / relevant include an example in the description, that could help all readers
  including project members to get a better picture of the change
• Avoid other runtime dependencies
• Meaningful commit history ; intention is important please rebase your commit history so that each
  commit is meaningful and help the people that will explore a change in 2 years
• The pull request follows coding style
• Mention Fixes #<issue number> in the description if relevant
• At least one commit should mention Fixes #<issue number> if relevant

Allows this kind of test to work in multiple test files:

import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.Mock;
import org.mockito.MockedConstruction;
import org.mockito.MockedStatic;
import org.mockito.junit.jupiter.MockitoExtension;

import static org.junit.jupiter.api.Assertions.assertNotNull;

@ExtendWith(MockitoExtension.class)
public class Test1 {

    @Test
    void testStatic(@Mock MockedStatic<ClassToMock> mockedStatic) {
        assertNotNull(mockedStatic);
    }

    @Test
    void testMockedConstruction(@Mock MockedConstruction<ClassToMock> mockConstruction) {
//        mockConstruction.closeOnDemand();
        assertNotNull(mockConstruction);
    }
}

Otherwise the mockConstruction object won't be closed and generate error described in #2281.

[TimvdLippe]

Please add the regression test that you mentioned in your PR description to our test suite in https://github.com/mockito/mockito/tree/main/subprojects/junit-jupiter/src/test/java/org/mockitousage

[temp-droid]

Hi @TimvdLippe , tests have been added. Feel free to mention if something needs to be changed!

Sorry if I messed up with the merge (not sure why it was needed), I hope we can squash everything before merging to hide it?

[raphw]

Obvious oversight. Good to merge.

[TimvdLippe]

Change looks good to me. We can clean up the commit message when we squash-merge, so don't worry about that 😄

Only a small nit with regard to the missing license. Other than that this is ready to go.

[TimvdLippe]

Argh, my apologies. Since this only works for the inline mockmaker, the test file needs to be in https://github.com/mockito/mockito/tree/main/subprojects/junitJupiterInlineMockMakerExtensionTest/src/test/java/org/mockitousage

Please run ./gradlew build locally to ensure that the tests pass before you update the PR.

[temp-droid]

No worries, and thank you for pointing that out, I was getting confused by the error message.

Also the project was building fine locally, which I find suspicious based on the error message I receive on Github.

[TimvdLippe]

Thanks for the fix!