Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadoc: monospace font fallback #2434

Merged
merged 1 commit into from Sep 24, 2021

Conversation

slauth
Copy link
Contributor

@slauth slauth commented Sep 24, 2021

I'm on Ubuntu and have none of the listed fonts installed. All code blocks are therefore rendered with a serif font which looks rather ugly. Adding the generic monospace family as fallback fixes this.

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2021

Codecov Report

Merging #2434 (e0fc246) into main (5653127) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #2434   +/-   ##
=========================================
  Coverage     86.40%   86.40%           
  Complexity     2761     2761           
=========================================
  Files           318      318           
  Lines          8299     8299           
  Branches       1015     1015           
=========================================
  Hits           7171     7171           
  Misses          854      854           
  Partials        274      274           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5653127...e0fc246. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants