Run CI on Java 17 #2417
Merged
Run CI on Java 17 #2417
+33
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2417 +/- ##
============================================
+ Coverage 85.45% 86.57% +1.12%
+ Complexity 2799 2762 -37
============================================
Files 330 318 -12
Lines 8478 8299 -179
Branches 1026 1015 -11
============================================
- Hits 7245 7185 -60
+ Misses 955 841 -114
+ Partials 278 273 -5
Continue to review full report at Codecov.
|
TimvdLippe
commented
Sep 1, 2021
| @@ -34,6 +35,7 @@ public void is_type_mockable_excludes_primitive_wrapper_classes() { | |||
| } | |||
|
|
|||
| @Test | |||
| @Ignore("Broken on JDK 17") | |||
There was a problem hiding this comment.
We were only running this on 17, but it seems to be failing anyways 😢
|
The CodeCov diff now shows we are correctly using the Java 16+ codepath for invoking the relevant proxy method in the proxy mockmaker. So everything is working as expected and we have more code coverage 🎉 |
|
@raphw Do you mind taking a look at the disabled test and let me know if that is intended? |
raphw
approved these changes
Sep 24, 2021
.github/workflows/ci.yml
Outdated
| @@ -26,7 +26,7 @@ jobs: | |||
| # Definition of the build matrix | |||
| strategy: | |||
| matrix: | |||
| java: [8, 11, 15] | |||
| java: [8, 11, 17-ea] | |||
| @@ -34,6 +35,7 @@ public void is_type_mockable_excludes_primitive_wrapper_classes() { | |||
| } | |||
|
|
|||
| @Test | |||
| @Ignore("Broken on JDK 17") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see how far we can get.