Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder InjectMock Javadoc to fit the order of injection #2383

Merged
merged 1 commit into from Aug 3, 2021
Merged

Reorder InjectMock Javadoc to fit the order of injection #2383

merged 1 commit into from Aug 3, 2021

Conversation

vogella
Copy link
Contributor

@vogella vogella commented Aug 3, 2021

InjectMock performs inject in the order of Construction, parameter and setter and it would be consistent to use this order in the initial explanation of the Javadoc.

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

InjectMock performs inject in the order of Construction, parameter and setter and it would be consistent to use this order in the initial explanation of the Javadoc.
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@TimvdLippe TimvdLippe merged commit 1a8750f into mockito:main Aug 3, 2021
@vogella
Copy link
Contributor Author

vogella commented Aug 3, 2021

Thanks @TimvdLippe for the fast merge.

@TimvdLippe
Copy link
Contributor

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants